-
Notifications
You must be signed in to change notification settings - Fork 3
feat: improved LaTeX check workflows #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… to a while loop; only put LaTeX errors in the prompt when requesting a rewriting (the error prompts haven't been tested yet, they are generated by llms); isolated LaTeX when beautifying;
✅ Deploy Preview for c13n-newsletter ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think it should be included in make.py rather than the writer since we may have older files that also need fixing. |
The code looks good for me. You could run the workflow in your forked repo to see the effects. |
Seems like the regex which matches valid TeX style math delimiters does not conform to our spec (available here). In short, the normal dollar signs should not be escaped as in the CommonMark spec. And I suggest using a finite state machine instead of regex to do the job. You may refer to the C implementation while implementing. |
Extended the LaTeX checks;
Moved the modificatioin process in to a while loop, to ensure the error is fixed;
Only put LaTeX errors in the prompt when requesting a rewriting (the error prompts haven't been tested yet, they are generated by llms);
Isolated LaTeX when beautifying;
Haven't test the code ever once... not sure if it works.